Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

setting MarkerView tilt when adding it to the map #7240

Merged
merged 1 commit into from
Nov 30, 2016
Merged

setting MarkerView tilt when adding it to the map #7240

merged 1 commit into from
Nov 30, 2016

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Nov 30, 2016

Related to #7239, tilt wasn't getting applied to MarkerViews.
Review @ivovandongen.

@tobrun
[android] - setting tilt value when animating visibility.
859cbcb 
Allow updating model even if MarkerView isn't in current viewport.
@tobrun tobrun added Android Mapbox Maps SDK for Android ✓ ready for review labels Nov 30, 2016
@tobrun tobrun added this to the android-v4.2.0 milestone Nov 30, 2016
@tobrun tobrun self-assigned this Nov 30, 2016
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @zugaldia and @1ec5 to be potential reviewers.

cammace
cammace approved these changes Nov 30, 2016
View reviewed changes
Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@tobrun tobrun merged commit b3ec26f into release-android-v4.2.0 Nov 30, 2016
@tobrun tobrun deleted the tobrun-tilt-markerviews branch November 30, 2016 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cammace cammace cammace approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v4.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobrun @mention-bot @cammace @1ec5