Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - max/min refactor #7306

Merged
merged 1 commit into from
Dec 15, 2016
Merged

[android] - max/min refactor #7306

merged 1 commit into from
Dec 15, 2016

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Dec 6, 2016 •
edited
Loading

This PR changes the following items:

  • move max/min zoom code from MapboxMap.java to Transform.java
  • cleanup usage of double vs float
  • renamed public API methods for parity reasons

Review @ivovandongen

@tobrun tobrun added Android Mapbox Maps SDK for Android ✓ ready for review labels Dec 6, 2016
@tobrun tobrun added this to the android-v5.0.0 milestone Dec 6, 2016
@tobrun tobrun self-assigned this Dec 6, 2016
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @zugaldia to be potential reviewers.

cammace
cammace approved these changes Dec 14, 2016
View reviewed changes
Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@tobrun tobrun merged commit f95b483 into master Dec 15, 2016
@tobrun tobrun deleted the tobrun-min-max-zoom branch December 15, 2016 15:57
@1ec5 1ec5 mentioned this pull request Mar 15, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cammace cammace cammace approved these changes

@ivovandongen ivovandongen Awaiting requested review from ivovandongen

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobrun @mention-bot @cammace @1ec5