This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
URL accessor for raster and vector sources #7398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
Core
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @incanus and @friedbunny to be potential reviewers. |
1ec5
force-pushed
the
1ec5-tile-layer-url
branch
from
d50baa5
to
f1330d3
Compare
1ec5
force-pushed
the
1ec5-tile-layer-url
branch
from
f1330d3
to
37768e9
Compare
Localize only Mapbox Streets v6–v7, and do so more systematically than before.
1ec5
force-pushed
the
1ec5-tile-layer-url
branch
from
37768e9
to
e7fa769
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to MGLTileSource (and thus MGLRasterSource and MGLVectorSource) that returns the TileJSON URL, if any, that was used to initialize the source. #7377 removed this method, but this PR adds it back in; this time, it works for sources obtained via
-[MGLStyle layerWithIdentifier:]too.The “Labels In” feature in macosapp now avoids localizing sources other than Mapbox Streets v6–7, demonstrating how tantalizingly close we are to implementing #7031.
Working towards #6584. Depends on #7377.
@ivovandongen to review the core parts; @frederoni to review the iOS/macOS parts.