This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Adds checkstyle to CI #7442
Merged
Adds checkstyle to CI #7442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cammace, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @zugaldia and @1ec5 to be potential reviewers. |
Can we just make it fail instead and fix up the code as part of this commit? |
added 15 commits
December 15, 2016 10:55
tobrun
approved these changes
Dec 16, 2016
10 tasks
9 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking #6232 back up, this adds gradle task and integrates with Bitrise. Just produces warning for now since there's still many violations in the code. I placed the task up pretty high in the script so that later when we start failing builds, it happens before we run our test.