[core] Get rid of user-specified refs #7586
Conversation
Only affects tests.
|
@jfirebaugh, thanks for your PR! By analyzing this pull request, we identified @yhahn, @tmpsantos and @ansis to be potential reviewers. |
| } | ||
|
|
||
| std::vector<std::vector<std::unique_ptr<Layer>>> groupByLayout(std::vector<std::unique_ptr<Layer>> layers) { | ||
| std::unordered_map<std::string, std::vector<std::unique_ptr<Layer>>> map; |
There was a problem hiding this comment.
std::vector<std::unique_ptr<Layer>> is getting repeated quite a bit. Do you think the code would benefit from a Layout typedef or somesuch?
There was a problem hiding this comment.
This method is short enough that I think it's ok.
| @@ -17,4 +18,12 @@ optional<Color> Color::parse(const std::string& s) { | |||
| }}; | |||
| } | |||
|
|
|||
| std::string Color::stringify() const { | |||
| return "rgba(" + | |||
There was a problem hiding this comment.
Does it matter that a Color created via an hsla() string would get converted back to JSON as an rgba() string?
There was a problem hiding this comment.
Named colors will also come back as rgba() strings; there are no guarantees that values are round-tripped exactly. This is consistent with GL JS and the CSSOM.
It should be safe to invoke GeometryTileWorker::setData multiple times without invoking GeometryTileWorker::setLayers. Therefore GeometryTileWorker::redoLayout() must not consume the layers.
It should be safe to invoke GeometryTileWorker::setData multiple times without invoking GeometryTileWorker::setLayers. Therefore GeometryTileWorker::redoLayout() must not consume the layers.
Fixes #6900
Fixes #7572