This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Distance formatter fixes #3331 #7592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
added
iOS
|
@frederoni, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @incanus to be potential reviewers. |
1ec5
approved these changes
Jan 4, 2017
There was a problem hiding this comment.
Looks good! Don’t forget to add this new class to the jazzy tables of contents and mention it in the changelogs.
This PR is targeted at the release-ios-v3.4.0 branch, but its milestone is set to iOS SDK v3.5.0, which is being developed on master. Do you want this PR to go into v3.4.1 instead?
| /** | ||
| `MGLDistanceFormatter` implements a formatter object meant to be used for | ||
| geographic distances. The user’s current locale will be used by default | ||
| but it can be overriden by changing the locale property of the numberFormatter. |
There was a problem hiding this comment.
Nit: surround locale and numberFormatter in backticks.
|
Not planning to merge until #7432 is mergeable which will be a nice real test case. I'll retarget this branch and aim for 3.5.0. |
|
Closing in favor of #7631 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3331
This PR adds a formatter that is meant to be used for geographic distances. (i.e. #7432)