This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Allow creation of shape collections with no shapes #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundsj
changed the title
1ec5
approved these changes
Jan 8, 2017
There was a problem hiding this comment.
Let’s add a test that this class’s conversion methods still work correctly with an empty shapes array.
Also, MGLShapeCollection’s documentation says “consisting of one or more … shapes” but should now say “zero or more”. Finally, since MGLShapeCollection existed in v3.3.0, you can add a blurb to the changelogs about this bug fix.
boundsj
force-pushed
the
boundsj-remove-shape-collection-assertion
branch
from
1e5c30e
to
aa48fac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7628