This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
WIP GLSurfaceView #7736
Closed
WIP GLSurfaceView #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobrun, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @incanus and @tmpsantos to be potential reviewers. |
tobrun
force-pushed
the
tvn-glsurfaceview-render
branch
from
2d4ffa7
to
3cf5e11
Compare
tobrun
force-pushed
the
tvn-glsurfaceview-render
branch
from
3cf5e11
to
d17b5be
Compare
|
continous in #8031 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, Closes #5766, this PR migrates from using SurfaceView as a drawing surface to a GLSurfaceView implementation. More information on this topic in #5766.
Current state:
*= it's currently unclear what next actions are to resolve this, currently queuing a runnable to be executed on the render thread is resulting in a native crash. I have tried instantiating the map object on the render thread itself but our runloop implementation doesn't agree with that.