Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Persist user tracking mode despite programmatic camera changes #7856

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Jan 25, 2017

Fixes #7789

The stuttering effect is not as noticeable as I first thought. Concurrent animations (#3625) might still be a blocker though.

animation

The transition is more or less smooth depending on the timing of the subsequent location update.

@bsudekum 👀

@mention-bot
Copy link

@frederoni, thanks for your PR! By analyzing this pull request, we identified @1ec5, @incanus and @boundsj to be potential reviewers.

@bsudekum
Copy link

@frederoni nice! Are there any other camera changing function that this should also be removed from?

I like @1ec5 summed it up:

In other words, we should avoid kicking the user out of user tracking mode due to a programmatic camera change, but still kick the user out of user tracking mode in response to a user gesture. This would fix #1490 as well.

@frederoni
Copy link
Contributor Author

frederoni commented Jan 25, 2017

All camera updating functions are chained so this change will impact all of them.

In other words, we should avoid kicking the user out of user tracking mode due to a programmatic camera change, but still kick the user out of user tracking mode in response to a user gesture. This would fix #1490 as well.

The change in this PR would fix that.

@1ec5
Copy link
Contributor

1ec5 commented Jan 25, 2017

@1ec5 1ec5 added this to the ios-v3.5.0 milestone Jan 25, 2017
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general labels Jan 25, 2017
@1ec5 1ec5 changed the title Persistent user tracking mode Persist user tracking mode despite programmatic camera changes Jan 26, 2017
@frederoni frederoni force-pushed the fred-persistent-user-tracking-7789 branch from cddd5d8 to 8f79fea Compare January 26, 2017 17:12
@frederoni
Copy link
Contributor Author

@1ec5 Good catch. Fixed in 8f79fea

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry to the iOS changelog.

@1ec5 1ec5 modified the milestones: ios-v3.4.2, ios-v3.5.0 Jan 26, 2017
@frederoni frederoni force-pushed the fred-persistent-user-tracking-7789 branch from 8f79fea to bf2b84b Compare January 27, 2017 15:03
@frederoni frederoni changed the base branch from master to release-ios-v3.4.0 January 31, 2017 11:57
@frederoni frederoni changed the base branch from release-ios-v3.4.0 to master January 31, 2017 11:58
@frederoni frederoni changed the base branch from master to release-ios-v3.4.0 January 31, 2017 12:38
@frederoni frederoni force-pushed the fred-persistent-user-tracking-7789 branch 3 times, most recently from be135ef to 5ee93ab Compare February 1, 2017 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS navigation For the Mapbox Navigation SDK for Android or iOS or navigation use cases in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants