This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Document DDS enumerations #7931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundsj
added
beta blocker
|
@boundsj, thanks for your PR! By analyzing this pull request, we identified @1ec5 and @friedbunny to be potential reviewers. |
boundsj
force-pushed
the
boundsj-darwin-dds-enum-docs
branch
from
185c4d7
to
7e94c79
Compare
1ec5
approved these changes
Feb 3, 2017
platform/darwin/src/MGLStyleValue.h
Outdated
| @@ -6,20 +6,70 @@ | |||
|
|
|||
| NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| // TODO: API docs | |||
| /** | |||
| Options for `MGLStyleValue` function objects. | |||
There was a problem hiding this comment.
Once #7934 is fixed, we can say these options are for MGLStyleFunction objects.
platform/darwin/src/MGLStyleValue.h
Outdated
| typedef NSString *MGLStyleFunctionOption NS_STRING_ENUM; | ||
|
|
||
| // TODO: API docs | ||
| /** | ||
| An `NSNumber` object containing an integer. |
There was a problem hiding this comment.
The first paragraph of the comment is the abstract; the abstract should be unique within the header or class. In this case, add "that determines the style function's exponential interpolation base".
boundsj
removed
the
⚠️ DO NOT MERGE
|
#7943 was merged |
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses enumeration todos noted in #7924