Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Post offline pack notifications from MGLOfflinePack #7952

Merged
merged 2 commits into from
Feb 6, 2017
Merged

Post offline pack notifications from MGLOfflinePack #7952

merged 2 commits into from
Feb 6, 2017

Conversation

eimantas
Copy link
Contributor

@eimantas eimantas commented Feb 6, 2017

Fixes #7908.

@mention-bot
Copy link

@eimantas, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @friedbunny to be potential reviewers.

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! It looks good to me. Would you do the honors and add a brief note to the iOS and macOS changelogs?

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline labels Feb 6, 2017
@1ec5 1ec5 added this to the ios-v3.5.0 milestone Feb 6, 2017
@eimantas
Copy link
Contributor Author

eimantas commented Feb 6, 2017

Done. Please check the changelog entries.

Eimantas Vaiciunas added 2 commits February 6, 2017 11:29
This commit also gets rid of private `MGLOfflinePackDelegate` protocol.
`userInfo` dictionary in notification objects retain the `state` and
`progress` values for backwards compatibility. They can be removed in
later major release.
@1ec5 1ec5 changed the title 7908 offline storage notifications Post offline pack notifications from MGLOfflinePack Feb 6, 2017
@1ec5 1ec5 merged commit 7b08810 into mapbox:master Feb 6, 2017
@1ec5
Copy link
Contributor

1ec5 commented Feb 6, 2017

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants