This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[node] Add request failure tests #8249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
force-pushed
the
tmpsantos-node_tests
branch
from
b408c80
to
4d62741
Compare
bsudekum
force-pushed
the
tmpsantos-node_tests
branch
from
4d62741
to
b1ca199
Compare
tmpsantos
force-pushed
the
tmpsantos-node_tests
branch
6 times, most recently
from
876d0f3
to
e35859a
Compare
|
@bsudekum don't know why the test is crashing on Linux. I can't reproduce it locally. :-/ |
tmpsantos
force-pushed
the
tmpsantos-node_tests
branch
2 times, most recently
from
9c26e0d
to
78675ac
Compare
tmpsantos
force-pushed
the
tmpsantos-node_tests
branch
3 times, most recently
from
8529cc4
to
562fe37
Compare
Test for timeout and when the request fails.
Tries to simulate the workload from api-gl.
Cancels an ongoing rendering.
tmpsantos
force-pushed
the
tmpsantos-node_tests
branch
from
562fe37
to
4eeab6f
Compare
tmpsantos
force-pushed
the
tmpsantos-node_tests
branch
from
1bb10c6
to
45840ad
Compare
bsudekum
reviewed
Apr 20, 2017
| // FIXME: Reload the style after recreating the map. We need to find | ||
| // a better way of canceling an ongoing rendering on the core level | ||
| // without resetting the map, which is way too expensive. | ||
| map->setStyleJSON(style); |
There was a problem hiding this comment.
I know at one point you said this might not work, is this still the case?
There was a problem hiding this comment.
What was not working is map->setStyleJSON("{}").
bsudekum
approved these changes
Apr 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for timeout and when the request fails.