This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
MyLocationView activate/deactivate LocationSource #8255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MyLocationView state.
zugaldia
approved these changes
Mar 2, 2017
| @@ -423,22 +421,18 @@ public void onRestoreInstanceState(Parcelable state) { | |||
| private void toggleGps(boolean enableGps) { | |||
| LocationEngine locationEngine = LocationSource.getLocationEngine(getContext()); | |||
| if (enableGps) { | |||
| // Set an initial location if one available | |||
| Location lastLocation = locationEngine.getLastLocation(); | |||
There was a problem hiding this comment.
@tobrun why not request a manual update? This way we could have a faster location reading before the LocationEngineListener receives the first update?
There was a problem hiding this comment.
can you clarify manual update? Expose a setter for end-users? or saving the last location ourselves? some background on why these lines were removed, this line will always return null as the LocationEngine hasn't been connected (this is due the change in LOST 1.0 -> 2.0).
tobrun
force-pushed
the
tvn-mylocationview-activate
branch
from
57bfbe4
to
7c1fe5b
Compare
8 tasks
This was referenced Mar 13, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues: