Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Include the telemetry service to simplify set up #8338

Merged
merged 3 commits into from
Mar 10, 2017
Merged

[android] Include the telemetry service to simplify set up #8338

merged 3 commits into from
Mar 10, 2017

Conversation

zugaldia
Copy link
Member

Fixes #8317.

@mention-bot
Copy link

@zugaldia, thanks for your PR! By analyzing this pull request, we identified @incanus to be potential reviewers.

tobrun
tobrun approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note is that we can remove the service declaration entry in testapp module

@zugaldia
Copy link
Member Author

@tobrun good thinking, I just removed it too and will merge once CI approves.

@zugaldia zugaldia merged commit 01f126c into release-ios-v3.5.0-android-v5.0.0 Mar 10, 2017
@zugaldia zugaldia deleted the 8317-manifest branch March 10, 2017 02:30
@zugaldia zugaldia mentioned this pull request Mar 10, 2017
Closed
8 tasks
@tobrun tobrun mentioned this pull request Mar 17, 2017
Closed
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zugaldia @mention-bot @tobrun