This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Expose Source::getZoomRange #8472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunoabinader, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @mourner and @1ec5 to be potential reviewers. |
jfirebaugh
approved these changes
Mar 20, 2017
jfirebaugh
reviewed
Mar 20, 2017
| @@ -153,7 +153,7 @@ void GeoJSONSource::Impl::loadDescription(FileSource& fileSource) { | |||
| }); | |||
| } | |||
|
|
|||
| Range<uint8_t> GeoJSONSource::Impl::getZoomRange() { | |||
| Range<uint8_t> GeoJSONSource::Impl::getZoomRange() const { | |||
| assert(loaded); | |||
There was a problem hiding this comment.
As hinted at more generally in the second point of this comment, this assert (and the equivalent one in TileSourceImpl) is likely to get triggered if we start using getZoomRange more widely. It may need to return optional<Range<uint8_t>>, so that callers are aware of the possibility of absence.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
Source::getZoomRangeas part ofSourcepublic API, also marking itconst.Part of #6584.