This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fixes #476: pixel / projected meter / lat/long conversions #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversions Conflicts: src/map/transform.cpp
…ordinate conversions
Conflicts: ios/mapbox-gl-cocoa
Conflicts: common/glfw_view.cpp include/mbgl/map/map.hpp include/mbgl/map/transform.hpp ios/mapbox-gl-cocoa src/map/map.cpp src/mbgl/map/transform.cpp styles test/headless.cpp
Conflicts: src/mbgl/renderer/painter.cpp
|
Ok, I think we're set here, including migrating API across OS X, iOS, Linux, and Android. Working on tests now. |
|
:-D |
Closed
| void setLonLatZoom(double lon, double lat, double zoom, std::chrono::steady_clock::duration duration = std::chrono::steady_clock::duration::zero()); | ||
| void getLonLatZoom(double &lon, double &lat, double &zoom) const; | ||
| void setLatLngZoom(LatLng latLng, double zoom, std::chrono::steady_clock::duration duration = std::chrono::steady_clock::duration::zero()); | ||
| void getLatLngZoom(LatLng &latLng, double &zoom) const; |
There was a problem hiding this comment.
Can we remove this method and use separate calls to getLatLng() and getZoom()?
There was a problem hiding this comment.
Yeah, I think so. This was just ported for historical reasons. Good reason to scrap it.
Closed
|
This is now working, so I'm inclined to merge it once it passes Travis and write tests in |
incanus
added a commit
that referenced
this pull request
Feb 16, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining:
conversionswork again and merge inmaster(over 1,000 commits).gl-cocoa#conversionschanges into this repo.TransformandTransformStateas a result of this branch + 4603ca0 (background image support /cc @jfirebaugh).gl-cocoa#conversionsto clean house.