This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Render parent raster tiles when tiles can't be loaded #8769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8164, we implemented raster tile overzooming. However, this fails in non-continuous rendering modes ("Still image rendering").
I believe this is a combination of two bugs, one of them in the node bindings, the other in
updateRenderables
:FileSource
doesn't support optional, so the code path for loading parent tiles is never triggered, and all tiles we attempt to load are not incomplete
state,complete
, but that never happens when a tile can't be loaded. This isn't an issue for continuous rendering because we just render what we have, but it's a termination condition for Still image rendering.JS test is in mapbox/mapbox-gl-js#4612
/cc @tmpsantos @bsudekum