This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use actors instead of explicit threads in (Default)FileSource #9100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivovandongen
added
Core
ivovandongen
force-pushed
the
default-filesource-actor
branch
4 times, most recently
from
e752d9f
to
4dda61c
Compare
ivovandongen
force-pushed
the
default-filesource-actor
branch
from
61fb0a7
to
345d7c4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make DefaultFileSource safe to share between threads, we need to make changes to how it handles state / communication with other FileSources, etc. This will enable us to share the DefaultFileSource between main and render/orchestration thread (#8820)
Also means changing other parts over to not use the (default) RunLoop anymore for mailbox handling:
SpriteLoader(::Loader)