[ios][android] SDK Bindings for Image Sources #9110

asheemmamoowala · 2017-05-25T21:53:26Z

This PR includes iOS/macOS and Android bindings for Image sources.

As per style spec, the Image Source accepts:

[longitude, latitude] pairs for the image corners listed in clockwise order: top left, top right, bottom right, bottom left.

In GL Native, this is represented as an std::vector<LatLng> for simplicity. For the iOS and Android APIs, we need to use a better structure/class to allow developers to easily and correctly provide the coordinates for their Image source.

The existing LatLngBounds objects in native, Obj-C, and Java are all aligned LatLng rects, where as ImageSource allows non-aligned rects. To support the non-aligned rects, this PR introduces LatLngQuad to represent four distinct LatLng pairs.

//cc @1ec5 @boundsj @zugaldia @ivovandongen @incanus

1ec5

To finish the iOS/macOS frontend for this feature:

Implement MGLImageSource.mm. There are helper methods in NSImage+MGLAdditions.h and UIImage+MGLAdditions.h for converting between Cocoa and mbgl image types. Note that these methods also treat template images as SDF icons.
Follow these instructions to ensure that MGLImageSource.h is integrated correctly into the module and documentation.
-[MGLStyle sourceFromMBGLSource:] needs an additional case to convert an ImageSource into an MGLImageSource.

1ec5 · 2017-05-26T18:00:54Z

platform/darwin/src/MGLGeometry.h

@@ -45,6 +45,18 @@ typedef struct MGLCoordinateBounds {
    CLLocationCoordinate2D ne;
 } MGLCoordinateBounds;

+typedef struct MGLCoordinateQuad {
+    /** Coordinate at the northwest corner. */
+    CLLocationCoordinate2D tl;


Let's write out these field names. It was a mistake to abbreviate the MGLCoordinateBounds fields.

1ec5 · 2017-05-26T18:02:54Z

platform/darwin/src/MGLGeometry.h

+    /** Coordinate at the northwest corner. */
+    CLLocationCoordinate2D tl;
+    /** Coordinate at the northeast corner. */
+    CLLocationCoordinate2D tr;


Is it top-right or northeast? Can the developer line up the top-right corner with the southwest geographic extent to rotate the image?

It should be top-right, not cardinal directions.

Ah, the documentation for these fields is a bit confusing in that case.

1ec5 · 2017-05-26T18:03:41Z

platform/darwin/src/MGLGeometry.h

@@ -45,6 +45,18 @@ typedef struct MGLCoordinateBounds {
    CLLocationCoordinate2D ne;
 } MGLCoordinateBounds;

+typedef struct MGLCoordinateQuad {


This struct needs a documentation comment in order for the struct to appear in jazzy documentation.

1ec5 · 2017-05-26T18:04:33Z

platform/darwin/src/MGLGeometry_Private.h

 /// Returns the smallest rectangle that contains both the given rectangle and
 /// the given point.
 CGRect MGLExtendRect(CGRect rect, CGPoint point);

 mbgl::LatLng MGLLatLngFromLocationCoordinate2D(CLLocationCoordinate2D coordinate);

+NS_INLINE std::vector<mbgl::LatLng> MGLLatLngFromLocationQuad(MGLCoordinateQuad quad) {


A more accurate name would be MGLalatLngsFromCoordinateQuad.

Excuse my phone keyboard… MGLatLngsFromCoordinateQuad

1ec5 · 2017-05-26T18:07:06Z

platform/darwin/src/MGLImageSource.h

+
+NS_ASSUME_NONNULL_BEGIN
+
+MGL_EXPORT


Similarly, we'll need some documentation here too. See the other source classes' documentation for examples. In particular, we should emphasize that this source is for georeferenced images; the SDK already has several other ways to put images on the map (MGLAnnotationImage, MGLAnnotationView with UIImageView, MGLStyle images).

1ec5 · 2017-05-26T18:08:53Z

platform/darwin/src/MGLImageSource.h

+ @param coordinates the NW, NE, SW, and SE coordiantes for the image.
+ @return An initialized image source.
+ */
+- (instancetype)initWithIdentifier:(NSString *)identifier coordinates:(MGLCoordinateQuad)coordinates NS_DESIGNATED_INITIALIZER;


Let's call the second parameter "coordinateQuad", since "coordinates" is usually the name of a C array of CLLocationCoordinate2Ds.

1ec5 · 2017-05-26T18:11:05Z

platform/darwin/src/MGLImageSource.h

+#pragma mark Initializing a Source
+
+/**
+ Returns an image source with an identifier and coordinates


Is it valid to create an image source without a URL or image, or to use it with a raster layer? What does it look like?

1ec5 · 2017-05-26T18:12:12Z

platform/darwin/src/MGLImageSource.h

+- (instancetype)initWithIdentifier:(NSString *)identifier coordinates:(MGLCoordinateQuad)coordinates NS_DESIGNATED_INITIALIZER;
+
+/**
+ Returns an image source with an identifier, coordinates and a URL


What image formats does this API accept?

1ec5 · 2017-05-26T18:14:02Z

platform/darwin/src/MGLImageSource.h

+ */
+@property (nonatomic, copy, nullable)NSURL *URL;
+
+@property (nonatomic, nullable, setter=setImage:)MGLImage *image;


-setImage: is the default setter name, so no need to specify it explicitly.

Does this property follow copy semantics, or does it retain the image strongly?

That brings up a good question, should there even be a getter for this property. The setImage: implementation will copy the data into an UnpremultipliedImage which gets moved to mbgl::style::ImageSource where there isn't a getImage() method.

Maybe the property should be replaced by a setImage: method?

Write-only properties are virtually unheard of in Objective-C and Swift. We would definitely want a getter if we have a setter. Ideally, there would be an mbgl::style::ImageSource::getImage(). If that isn’t possible, consider keeping parallel state in MGLImageSource (but see #7375).

What would be the compelling reason to maintain parallel state?
From #7376 (comment) this is only needed if developers are continuously modifying the source data. I can surely image that to be true for images, but that might mean we should implement and support video or some other means of showing that data - custom source/layer perhaps.

The only reason for maintaining parallel state would be as a last resort for implementing an image getter. mbgl::style::ImageSource::getImage() would make that unnecessary.

Having an image getter would make MGLImageSource consistent with -[MGLStyle imageForName:] for non-georeferenced images. It would also enable some of the same use cases as that method. Off the top of my head, an application could get the image from the source, manipulate it, and pass the manipulated image back to the source. Or the user could tap on an image source and the application would display the “selected” source’s image in an image view on the side. The application doesn’t have to keep track of the image itself; mbgl remains the source of truth.

Continuously modifying the source data could in some cases be better served by video sources; on the other hand, it’s much more feasible for an application to programmatically generate an image than a video.

Are there technical reasons against adding a getImage() in mbgl?

Consider the following situations

// A id imgSource = [[ImageSource alloc] initiWithIdentifier:@"foo" coordinates:c imageURL: url]; UIImage * img = imgSource.image; //no image data is available // B id imgSource = [[ImageSource alloc] initiWithIdentifier:@"foo" coordinates:c image: myImage]; imgSource.URL = "http://host/myimage.png"; UIImage * img = imgSource.image; //no image data is available

Under scenario A mbgl::ImageSource will resolve the url asynchronously and hold on to an UnassociatedImage until the next render pass. The image data is then moved to the bucket and a copy is not held in mbgl::ImageSource

Conceptually MGLImageSource.image is the image being used by the source, but given that it could be set via URL or directly breaks my mental model of being able to access the resolved image data when using a url.

I think it’s fine for the property to have a getter with the caveat that it remains unset if the source is created from a URL. For precedent, MGLTileSource.configurationURL is unset if the raster or vector source was created using tile URL templates instead of a TileJSON URL.

1ec5 · 2017-05-26T18:18:48Z

platform/darwin/src/MGLImageSource.h

+
+@property (nonatomic, nullable, setter=setImage:)MGLImage *image;
+
+@property (nonatomic, nonnull)CLLocationCoordinate2D * coordinates;


Since the initializers take an MGLCoordinateQuad, this property should be typed as an MGLCoordinateQuad too.

ivovandongen

@asheemmamoowala The interfaces for the Android API look good to me. Some small remarks.

ivovandongen · 2017-05-31T09:45:56Z

platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/geometry/LatLngQuad.java

+ */
+public class LatLngQuad implements Parcelable {
+
+  private final LatLng mTopLeft;


You can drop the Hungarian notation. We are not using that anymore since #6109

ivovandongen · 2017-05-31T09:48:34Z

platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/geometry/LatLngQuad.java

+ * This class does not wrap valies to the world bounds
+ * </p>
+ */
+public class LatLngQuad implements Parcelable {


Naming wise; NonAlignedLatLongBounds? Makes it very clear what the relation to LatLngBounds is. cc @tobrun

In iOS, this is MGLCoordinateQuad, so I wanted to try and use similar terminology.

Regarding the Objective-C struct’s name, it may be worth seeing if there’s precedent for a concept like this in SceneKit or SpriteKit and naming the struct accordingly. The Objective-C struct’s name doesn’t have to match the Java class’s name – after all, the Android SDK has LatLng and the iOS/macOS SDK has CLLocationCoordinate2D.

@1ec5 I looked through SpriteKit, SceneKit, and the Maps APIs for HERE, Tangram, Google, Amazon and Yandex. None of those have a concept of a non-aligned rect. Beyond rects, they all support polygons or arrays of points.

Im going to add convenience methods to support LatLngBounds and MGLCoordinateBounds for the SDKs. This avoids the awkwardness of the *Quad/NonAlignedBounds names for those who have regular aligned images

ivovandongen · 2017-05-31T09:49:23Z

platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/geometry/LatLngQuad.java

+   * Construct a new LatLngQuad based on its corners,
+   * in order top left, top right, bottom left, bottom right
+   */
+  LatLngQuad(final LatLng tl, final LatLng tr, final LatLng br, final LatLng bl) {


Please spell out the variable names, eg topLeft, etc

1ec5 · 2017-06-01T08:19:06Z

This PR depends on #8968.

jfirebaugh · 2017-06-05T20:05:41Z

There's a warning in the darwin builds that we should make sure is fixed in this PR:

⚠️  /Users/john/Development/mapbox-gl-native/platform/darwin/src/MGLOfflineStorage.mm:83:21: enumeration value 'Image' not handled in switch [-Wswitch]

            switch (kind_) {

1ec5 · 2017-06-13T17:50:22Z

One more thing: this feature is worth mentioning in the Android, iOS, and macOS changelogs.

1ec5

This is getting a lot closer. Most of the comments below are relatively minor, but there are still some rough edges around MGLImageSource’s initializers and image property.

1ec5 · 2017-06-13T23:04:26Z

platform/ios/CHANGELOG.md

@@ -2,6 +2,10 @@

 Mapbox welcomes participation and contributions from everyone. Please read [CONTRIBUTING.md](../../CONTRIBUTING.md) to get started.

+## master


The “3.6.0” section below is mistitled: it should be “master”. There’s a second “3.6.0” section below that corresponds to the actual 3.6.0 release.

1ec5 · 2017-06-13T23:08:11Z

platform/ios/CHANGELOG.md

@@ -2,6 +2,10 @@

 Mapbox welcomes participation and contributions from everyone. Please read [CONTRIBUTING.md](../../CONTRIBUTING.md) to get started.

+## master
+* Add support for ImageSource [#9110](https://github.com/mapbox/mapbox-gl-native/pull/9110)


For the iOS and macOS changelogs, please use a complete sentence that explains the purpose of the addition (and uses the correct class name). Something along these lines:

Added the MGLImageSource class for displaying a georeferenced image. (#9110)

1ec5 · 2017-06-13T23:09:39Z

platform/macos/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog for Mapbox macOS SDK

+## master


Similarly, the “3.6.0” section below should say “master”. I believe this was a botched merge conflict; the macOS SDK’s next release will be v0.6.0, not v3.6.0.

1ec5 · 2017-06-13T23:14:03Z

platform/darwin/src/MGLImageSource.h

+ @param coordinateQuad The top left, top right, bottom right, and bottom left coordinates for the image.
+ @return An initialized image source.
+ */
+- (instancetype)initWithIdentifier:(NSString *)identifier coordinates:(MGLCoordinateQuad)coordinateQuad NS_DESIGNATED_INITIALIZER;


Let’s call the second parameter coordinateQuad. I should’ve been clearer in #9110 that I was referring to the parameter’s label as well as the local parameter name.

1ec5 · 2017-06-13T23:15:21Z

platform/darwin/test/MGLDocumentationExampleTests.swift

@@ -104,6 +104,20 @@ class MGLDocumentationExampleTests: XCTestCase, MGLMapViewDelegate {
        XCTAssertNotNil(mapView.style?.source(withIdentifier: "pois"))
    }

+    func testMGLImageSource() {
+        //#-example-code
+        let coordinates: MGLCoordinateQuad = MGLCoordinateQuad(


It’s unnecessary to specify the type as MGLCoordinateQuad here. Swift can infer the type, similar to how the auto keyword works in C++.

1ec5 · 2017-06-13T23:48:25Z

platform/darwin/src/MGLOfflineStorage.h

@@ -154,6 +154,8 @@ typedef NS_ENUM(NSUInteger, MGLResourceKind) {
    /** JSON part of a sprite sheet. It is constructed of the prefix in
        https://www.mapbox.com/mapbox-gl-js/style-spec/#root-sprite and a JSON file extension. */
    MGLResourceKindSpriteJSON,
+    /** Image **/


We should clarify that it’s specifically an image source’s image (as opposed to an icon image or annotation image, aka sprite).

1ec5 · 2017-06-13T23:54:36Z

platform/ios/ios.xcodeproj/project.pbxproj

@@ -1954,7 +1973,6 @@
 				TargetAttributes = {
 					DA1DC9491CB6C1C2006E619F = {
 						CreatedOnToolsVersion = 7.3;
-						DevelopmentTeam = GJZR2MEM28;


How’d that sneak in there in the first place? 😅

1ec5 · 2017-06-14T00:05:02Z

platform/darwin/src/MGLImageSource.h

+/**
+ `MGLImageSource` is a map content source that supplies a georeferenced raster
+ image to be shown on the map. The geographic location of the raster image content, 
+ supplied with `MGLCoordinateQuad`, can be non-axis aligned.


Per #9110, we should point out that we have different ways to handle non-georeferenced images:

An image source is used for a georeferenced image – that is, an image in which the contents correspond to physical locations on the map. The georeferenced image scales and rotates as the user zooms and rotates the map. Images may also be used as icons or patterns in a style layer. To register an image for use as an icon or pattern, use the -[MGLStyle setImage:forName:] method. To configure a point annotation’s image, use the MGLAnnotationImage class.

1ec5 · 2017-06-14T00:06:04Z

platform/darwin/src/MGLImageSource.h

+#pragma mark Initializing a Source
+
+/**
+ Returns a georeferenced image source with an identifier and coordinates


What does it look like when you add an image source without content and use it in a raster layer? Does an error occur, or does it succeed silently with no visual effect?

The more I think about this, it doesn't make sense to partially initialize this type of source. Will just remove this initializer. That swill also reduce our initializers down to 4 which seems more reasonable

On the other hand, we do make it possible to create an MGLShapeSource with no shape and fill in the shape later. Developers have found that pattern to be very useful. If it isn’t too much trouble to support that pattern for image sources as well (without throwing errors and the like), that would be very nice, but not a blocker for landing this feature.

1ec5 · 2017-06-14T00:07:54Z

platform/ios/src/UIImage+MGLAdditions.h

@@ -10,6 +10,8 @@ NS_ASSUME_NONNULL_BEGIN

 - (std::unique_ptr<mbgl::style::Image>)mgl_styleImageWithIdentifier:(NSString *)identifier;

+- (mbgl::PremultipliedImage)mgl_PremultipliedImage;


Nit: mgl_premultipliedImage would be a more natural spelling for this method name.

1ec5 · 2017-06-14T00:17:20Z

This guide needs to be updated with the new source type.

asheemmamoowala · 2017-06-15T01:50:26Z

@ivovandongen @tobrun can one of you take a look at the updated implementation

ivovandongen

Looks great! Few minor nits.

ivovandongen · 2017-06-15T09:08:40Z

...android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/sources/ImageSource.java



 /**
 * Image source
- *
- *  * @see <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources-image">the style specification</a>
+ * <p>


NIT; I believe empty <p> elements will break javadoc generation still

ivovandongen · 2017-06-15T09:10:21Z

...p/src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/AnimatedImageSourceActivity.java

+
+import com.mapbox.mapboxsdk.testapp.R;
+
+public class AnimatedImageSourceActivity extends AppCompatActivity implements OnMapReadyCallback {


NIT; a short description of what the class is for (even though it is fairly obvious :))

ivovandongen · 2017-06-15T09:13:56Z

platform/android/src/style/conversion/latlngquad.hpp

+
+template <>
+optional<std::array<LatLng, 4>> Converter<std::array<LatLng, 4>>::operator()(const mbgl::android::Value& value, Error& error) const {
+    if(value.isNull() || !value.isArray()) {


nit; space after if

ivovandongen · 2017-06-15T09:14:53Z

platform/android/src/style/sources/image_source.hpp

@@ -16,7 +19,7 @@ class ImageSource : public Source {

    static void registerNative(jni::JNIEnv&);

-    ImageSource(jni::JNIEnv&, jni::String, jni::Object<>);
+    ImageSource(jni::JNIEnv&, jni::String, jni::Object<LatLngQuad> coordinatesObject);


You can leave out the param name here

1ec5

One more round of feedback, nothing major.

For better or worse, we’ve also hard-coded lists of subclasses in abstract superclass documentation, with the goal of providing navigational landmarks to developers (see #9095 for example). The MGLSource documentation will need to be updated to note the existence of MGLImageSource. (Perhaps in the future we’ll autogenerate these source headers as well, but the headers differ so much from the style specification’s structure that we’re maintaining these subclass lists by hand for now.)

1ec5 · 2017-06-16T17:12:42Z

platform/ios/CHANGELOG.md

+
+### Styles
+
+* Added suuport for diplaying georeferenced images via the `MGLImageSource`.  [#9110](https://github.com/mapbox/mapbox-gl-native/pull/9\


A stray backslash snuck into this URL.

1ec5 · 2017-06-16T17:15:55Z

platform/darwin/docs/guides/For Style Authors.md.ejs

@@ -178,8 +178,9 @@ In style JSON | In the SDK
 `geojson`     | `MGLShapeSource`
 `raster`      | `MGLRasterSource`
 `vector`      | `MGLVectorSource`
+`image`       | `MGLImageSource`


Note that this is an .ejs file, which means it’s a template for the runtime styling codegen tool. After running make darwin-style-code, you should see these changes propagate to the iOS- and macOS-specific Markdown files.

1ec5 · 2017-06-16T17:22:09Z

platform/darwin/src/MGLImageSource.h

+    current application’s resource bundle.
+ @return An initialized shape source.
+ */
+- (instancetype)initWithIdentifier:(NSString *)identifier coordinateQuad:(MGLCoordinateQuad)coordinateQuad imageURL:(NSURL *)url;


This will bridge to Swift as init(identifier:coordinateQuad:image:), which is a bit misleading. (Since Objective-C conventionally describes the type in argument labels where Swift omits them, the Swift compiler tries to remove such words from argument labels when bridging Objective-C methods.) We can prevent this situation by replacing imageURL: with URL:, which is also consistent with -[MGLShapeSource initWithIdentifier:URL:options:].

1ec5 · 2017-06-16T17:43:25Z

platform/darwin/src/MGLImageSource.h

+@property (nonatomic, retain, nullable)MGLImage *image;
+
+/**
+ The coordinates at which the source image will be placed.


Nit: these are the coordinates at which the corners of the source image will be placed.

Incidentally, this suggests another possible name for MGLCoordinateQuad: MGLCoordinateCorners. Indeed, there’s already a bitmask on iOS called UIRectCorner. But I’m comfortable with “coordinate quad” since it does have precedent in graphics programming.

1ec5 · 2017-06-16T17:50:21Z

platform/darwin/src/MGLGeometry.h

+ Creates a new `MGLCoordinateQuad` structure from the given top left, top right,
+  bottom right, and bottom left coordinates .
+ */
+NS_INLINE MGLCoordinateQuad MGLCoordinateQuadMake(CLLocationCoordinate2D topLeft, CLLocationCoordinate2D topRight, CLLocationCoordinate2D bottomRight, CLLocationCoordinate2D bottomLeft) {


These parameters should go in the same order as the fields are declared above, to ensure consistency between Objective-C and Swift.

1ec5 · 2017-06-16T17:55:27Z

platform/darwin/test/MGLImageSourceTests.m

+
+- (void)testMGLImageSourceWithImageURL {
+
+    MGLCoordinateQuad quad = { { 80, 37}, { 80, 39}, { 81, 39}, { 81, 37}};


These coordinates appear to be listed in BL/BR/TL/TR order, whereas the struct’s fields are declared in TL/BL/BR/TR order. (×2) Using the designated initializer syntax would head off this mistake, but I wonder if we should introduce a runtime check as well. (A runtime check can be tail work, but we should correct this test before merging.)

In this test we dont really care about how an image is placed, so the coordinate order can be fixed for someone else to understand.
In general though the corner coordinates are relative to the image, and can be used to rotate an image for placement. The top left corner does not have to be the north eastern coordinate.

That’s reasonable, although in this case the order would result in a non-quadrilateral, wouldn’t it?

1ec5 · 2017-06-16T17:58:44Z

platform/macos/macos.xcodeproj/project.pbxproj

@@ -271,6 +274,10 @@
 /* End PBXCopyFilesBuildPhase section */

 /* Begin PBXFileReference section */
+		07A019EA1ED662D800ACD43E /* MGLImageSource_Private.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MGLImageSource_Private.h; sourceTree = "<group>"; };


This file no longer exists.

😕 I deleted it from the IDE

That’s the correct (only) way to do it; however, the macOS project is currently separate from the iOS project, even though they share many files. So you need to also open up make xproj and delete the (now broken) reference to the file from that project as well. #5942 would merge the two projects, avoiding this complication in the future. (Also, the new build system in Xcode 9 more heavily emphasizes the file system, so it’s possible that Apple will solve this problem for us.)

…se animated ImageSource demo in iOS test app

1ec5

All set!

asheemmamoowala · 2017-06-19T16:50:02Z

Closes #1350 and #9295

asheemmamoowala added Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels May 25, 2017

asheemmamoowala mentioned this pull request May 26, 2017

[core][node] Support ImageSource #8968

Merged

5 tasks

1ec5 reviewed May 26, 2017

View reviewed changes

tobrun requested a review from ivovandongen May 26, 2017 19:33

ivovandongen reviewed May 31, 2017

View reviewed changes

1ec5 mentioned this pull request Jun 1, 2017

Support "image" source type #1350

Closed

asheemmamoowala force-pushed the image-source-bindings branch 4 times, most recently from 38e8dbe to 579aeae Compare June 13, 2017 08:17

asheemmamoowala force-pushed the image-source-bindings branch 2 times, most recently from 2c25274 to bbf972b Compare June 13, 2017 21:08

1ec5 reviewed Jun 14, 2017

View reviewed changes

asheemmamoowala force-pushed the image-source-bindings branch from bbf972b to 8ffbd43 Compare June 15, 2017 01:59

ivovandongen approved these changes Jun 15, 2017

View reviewed changes

asheemmamoowala force-pushed the image-source-bindings branch from 8ffbd43 to eba51de Compare June 15, 2017 21:13

asheemmamoowala removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jun 15, 2017

asheemmamoowala changed the title ~~[ios][android] Draft API interfaces for ImageSource~~ [ios][android] SDK Bindings for Image Sources Jun 15, 2017

1ec5 added GL JS parity For feature parity with Mapbox GL JS runtime styling labels Jun 16, 2017

1ec5 reviewed Jun 16, 2017

View reviewed changes

friedbunny mentioned this pull request Jun 16, 2017

Image Artifacts Remain After Adding/Removing Symbol Layer #9249

Closed

Asheem Mamoowala added 5 commits June 16, 2017 13:42

[iOS][macOS] Add ImageSource bindings

6f3e035

[android] Add ImageSource bindings

f404313

[iOS][macOS] Export MGLImageSource, add and update documentation. U…

a0165f2

…se animated ImageSource demo in iOS test app

Update changelogs and iOS/macOS style guide for ImageSource bindings

d6f8910

[core] Trigger repaint on source changes

37fa8ad

asheemmamoowala force-pushed the image-source-bindings branch from eba51de to 37fa8ad Compare June 16, 2017 21:19

1ec5 approved these changes Jun 16, 2017

View reviewed changes

asheemmamoowala mentioned this pull request Jun 18, 2017

Cannot update MGLShapeSource shape property #9295

Closed

asheemmamoowala merged commit a33cad9 into master Jun 19, 2017

asheemmamoowala deleted the image-source-bindings branch June 19, 2017 17:16

This was referenced Jun 19, 2017

IOS : Updating MGLShapeSource with MGLShape is not working. #9229

Closed

Image Source Example mapbox/ios-sdk-examples#93

Closed

1ec5 mentioned this pull request Jul 5, 2017

Merge release-ios-v3.6.0-android-v5.1.0 #9416

Merged

langsmith mentioned this pull request Aug 4, 2017

Image source example mapbox/mapbox-android-demo#437

Closed

Guardiola31337 mentioned this pull request Oct 6, 2017

Release Android v5.2.0-beta.1 #10140

Closed

20 tasks

Guardiola31337 added this to the android-v5.2.0 milestone Oct 6, 2017

1ec5 mentioned this pull request Oct 13, 2017

Make places and roads accessible to VoiceOver #9950

Merged

15 tasks

Guardiola31337 mentioned this pull request Oct 19, 2017

Release Android v5.2.0-beta.2 #10239

Closed

20 tasks

Guardiola31337 mentioned this pull request Oct 26, 2017

Release Android v5.2.0 beta.3 #10297

Closed

20 tasks

tobrun mentioned this pull request Nov 3, 2017

Release Android v5.2.0-beta.4 #10379

Closed

21 tasks

This was referenced Nov 14, 2017

Release Android v5.2.0-beta.5 #10463

Closed

Release Android v5.2.0 #10486

Closed


		@property (nonatomic, nullable, setter=setImage:)MGLImage *image;

		@property (nonatomic, nonnull)CLLocationCoordinate2D * coordinates;

		@@ -2,6 +2,10 @@

		Mapbox welcomes participation and contributions from everyone. Please read [CONTRIBUTING.md](../../CONTRIBUTING.md) to get started.

		## master

		@@ -10,6 +10,8 @@ NS_ASSUME_NONNULL_BEGIN

		- (std::unique_ptr<mbgl::style::Image>)mgl_styleImageWithIdentifier:(NSString *)identifier;

		- (mbgl::PremultipliedImage)mgl_PremultipliedImage;


		import com.mapbox.mapboxsdk.testapp.R;

		public class AnimatedImageSourceActivity extends AppCompatActivity implements OnMapReadyCallback {


		### Styles

		* Added suuport for diplaying georeferenced images via the `MGLImageSource`. [#9110](https://github.com/mapbox/mapbox-gl-native/pull/9\


		- (void)testMGLImageSourceWithImageURL {

		MGLCoordinateQuad quad = { { 80, 37}, { 80, 39}, { 81, 39}, { 81, 37}};


		NS_ASSUME_NONNULL_BEGIN

		MGL_EXPORT

[ios][android] SDK Bindings for Image Sources #9110

[ios][android] SDK Bindings for Image Sources #9110

Conversation

asheemmamoowala commented May 25, 2017 • edited Loading

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivovandongen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asheemmamoowala Jun 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 commented Jun 1, 2017

jfirebaugh commented Jun 5, 2017

1ec5 commented Jun 13, 2017

1ec5 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asheemmamoowala Jun 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 commented Jun 14, 2017

asheemmamoowala commented Jun 15, 2017

ivovandongen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Jun 16, 2017 • edited Loading

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

asheemmamoowala commented Jun 19, 2017

asheemmamoowala commented May 25, 2017 •

edited

Loading

asheemmamoowala Jun 7, 2017 •

edited

Loading

1ec5 left a comment •

edited

Loading

asheemmamoowala Jun 14, 2017 •

edited

Loading

1ec5 Jun 16, 2017 •

edited

Loading