Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

clean up members, arguments, and formatting #937

Merged
merged 2 commits into from
Mar 3, 2015
Merged

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Mar 3, 2015

Hit some weirdness over in #928 with the naming here and posting some cleanups.

  • Since we're dealing with both VectorTileData (base: TileData) and VectorTile classes, we should refer to raw data retrieved from a vector tile download and used to instantiate a VectorTile as raw_data, not just data.
  • The VectorTile instantiated is now called vector_tile, not vector_data.
  • The VectorTileData& tile is not ideal, since elsewhere in the project we also have a Tile class, but for the purposes of convenience throughout the implementation, it stays.
  • Overall formatting changes like ClassName& argument_name — reference & next to type, then a space, then the variable name with _ and not camelCase.

kyleve_2015-jan-07

@incanus
Copy link
Contributor Author

incanus commented Mar 3, 2015

BTW explicit mention of vector tiles will go away soon, once #928 lands and I'm back on #893 ;-)

@jfirebaugh
Copy link
Contributor

Looks good but we are moving toward camelCase variable names, not underscore: #399.

@incanus
Copy link
Contributor Author

incanus commented Mar 3, 2015

Cool, will fix while I'm in there.

@incanus
Copy link
Contributor Author

incanus commented Mar 3, 2015

Moved to camelCase for members and externally-available arguments.

incanus added a commit that referenced this pull request Mar 3, 2015
clean up members, arguments, and formatting
@incanus incanus merged commit 80d8d15 into master Mar 3, 2015
@incanus incanus deleted the tile-parser-cleanups branch March 3, 2015 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants