This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
clean up members, arguments, and formatting #937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit some weirdness over in #928 with the naming here and posting some cleanups.
VectorTileData
(base:TileData
) andVectorTile
classes, we should refer to raw data retrieved from a vector tile download and used to instantiate aVectorTile
asraw_data
, not justdata
.VectorTile
instantiated is now calledvector_tile
, notvector_data
.VectorTileData& tile
is not ideal, since elsewhere in the project we also have aTile
class, but for the purposes of convenience throughout the implementation, it stays.ClassName& argument_name
— reference&
next to type, then a space, then the variable name with_
and notcamelCase
.