This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[benchmark] add render benchmarks #9449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
approved these changes
Jul 7, 2017
benchmark/api/render.benchmark.cpp
Outdated
| }; | ||
|
|
||
| static void prepare(Map& map) { | ||
| map.getStyle().loadJSON(util::read_file("benchmark/fixtures/api/query_style.json")); |
There was a problem hiding this comment.
Can we have a copy of this style specifically for this test? Or rename it to style.json so we know it is used by 1+ benchmarks.
| } | ||
| } | ||
|
|
||
| static void API_renderStill_recreate_map(::benchmark::State& state) { |
There was a problem hiding this comment.
I would like to suggest another benchmark. One that reuses the map but sets the style to {} before setting the actual style.
There was a problem hiding this comment.
ivovandongen
force-pushed
the
ivd-render-benchmark
branch
from
f93bda1
to
1728f76
Compare
ivovandongen
force-pushed
the
ivd-render-benchmark
branch
from
1728f76
to
b5745be
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two render tests to be able to test #8820 (and specifically #9327).
Depends on #9446