Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Current Scheduler #9728

Merged
merged 5 commits into from
Aug 9, 2017
Merged

Current Scheduler #9728

merged 5 commits into from
Aug 9, 2017

Conversation

ivovandongen
Copy link
Contributor

Extracted the current Scheduler part of #9611 as requested:

This PR adds an abstraction on top of the RunLoop so that we can Schedule work on arbitrary schedulers. This is important for asynchronous rendering where we are dealing with threads without a runloop that need to defer scheduling of additional work to another thread scheduler and/or use another form of scheduling than a RunLoop (see #9576).

In certain places we will still work with the RunLoop directly where it's needed (OnlineFileSource, AsyncTask)

@ivovandongen ivovandongen added the Core The cross-platform C++ core, aka mbgl label Aug 8, 2017
@ivovandongen ivovandongen self-assigned this Aug 8, 2017
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grepping for RunLoop::Get shows some remaining usage that should be changed to Scheduler::Get: android/src/file_source.cpp, darwin/src/MGLOfflineStorage.mm, and the comment in scheduler.hpp that you updated in the combined PR. Looks good other than that.

@ivovandongen ivovandongen merged commit f4f4d13 into master Aug 9, 2017
@ivovandongen ivovandongen deleted the ivd-current-scheduler-cleaned branch August 9, 2017 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants