-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add an entry to the Android, iOS, and macOS changelogs about the increased maximum maximum? Thanks!
@@ -508,7 +508,9 @@ public double getMinZoomLevel() { | |||
* <p> | |||
* Sets the maximum zoom level the map can be displayed at. | |||
* </p> | |||
* | |||
* <p> | |||
* The default maximum zoomn level is 22. The upper bound for this value is 25.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: “zoomn”.
@@ -597,7 +597,8 @@ MGL_EXPORT IB_DESIGNABLE | |||
* If the value of this property is smaller than that of the | |||
* minimumZoomLevel property, the behavior is undefined. | |||
* | |||
* The default maximumZoomLevel is 20. | |||
* The default maximumZoomLevel is 22. The upper bound for this property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Property names should be in backticks to benefit from jazzy’s autolinking feature. However, let’s say “default value of this property” here for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1ec5 - In this case its referring to itself, so this shouldn't need any linking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that’s why I suggested saying “default value of this property”, same as what you had written for macOS. No big deal though.
f8d6c5f
to
55d6b4e
Compare
Are there any prerequisites or blockers that would keep these maxzoom changes from being cherry-picked into the current release branch? |
@friedbunny - I think #9820 and #4168 (for Android only) should be looked at to make sure they are either acceptable or not an issue. |
55d6b4e
to
f116ef7
Compare
Update iOS documentation and use DEFAULT_MAX_ZOOM constant.
+CHANGELOGs