Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

v8 Omnibus 2 #993

Closed
wants to merge 24 commits into from
Closed

v8 Omnibus 2 #993

wants to merge 24 commits into from

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Mar 12, 2015

Downstream issue of mapbox/mapbox-gl-style-spec#264

@tmcw tmcw mentioned this pull request Mar 12, 2015
82 tasks
@tmcw
Copy link
Contributor Author

tmcw commented Mar 16, 2015

/cc @jfirebaugh @kkaefer would love some assistance on this patch so that it doesn't get merge-pwned by changes in the master branch. This is needed to close https://github.com/mapbox/mapbox-gl-online/issues/1300 in gl-online and has completed twin issues in gl-style-spec and gl-js: I'm trying to implement style v8 compatibility and have a goal of:

  • for the text-font property, it should now be an array of strings instead of a comma-separated string
  • the least invasive way to implement this would be to comma-join the array as soon as it enters gl-native
  • but the template approach means that we'll have to do some sort of templating magic to make this flow different than other arrays

@kkaefer
Copy link
Member

kkaefer commented Mar 17, 2015

@tmcw looks like you figured it out? The only thing missing is changing the style fixtures since the style format changed.

@tmcw
Copy link
Contributor Author

tmcw commented Mar 17, 2015

Yep, forgot to post back here - sorry. The text-font issue is now fixed, but we then came to the agreement that we should go whole-hog and implement types too, which I'll do first in style-spec.

@tmcw
Copy link
Contributor Author

tmcw commented Apr 17, 2015

In the interest of shipping v8 sooner rather than later, does anyone @mapbox/gl want to adopt this side of the (spec, js, api, native) taskcombo?

@lbud lbud mentioned this pull request Apr 29, 2015
3 tasks
@lbud
Copy link
Contributor

lbud commented Apr 30, 2015

#1390 …maybe

@lbud
Copy link
Contributor

lbud commented May 13, 2015

Closing in favor of #1390

@lbud lbud closed this May 13, 2015
@lbud lbud deleted the v8-two branch May 13, 2015 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants