This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Align line vertex to 4-byte boundary #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 byte vertices are heavily penalized by common GL implementations. Cherry-picks aa4dff1
boundsj
approved these changes
Sep 11, 2017
|
@jfirebaugh the build failures here and in #9942 are ticketed in #9940. The iOS team are considering making the Travis check optional for this branch, for now, to unblock our last set of iOS specific PRs for the v3.6.3 patch release (which should be the last release on this branch). Can we use that approach to workaround the blocker here or does #9940 need to be resolved somehow? |
|
Yeah, that seems fine. |
kkaefer
approved these changes
Sep 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10 byte vertices are heavily penalized by common GL implementations.
Cherry-picks aa4dff1