Differences that need resolution

[jfirebaugh]

Eventually there should be no appearances of #if[n]def MAPBOX_GL_JS in the shader sources.

• missing in native: "#mapbox pragma" commands support
• missing in native: overdraw inspector
• circle
  • missing in native: convert mat4 exMatrix to a vec2 extrudeScale
  • missing in native: Enabled data-driven styling for circle-radius
  • missing in native: Reduce shader boilerplate, refactor "Bucket"
• collisionbox
• debug
• fill
  • missing in native: separate u_opacity from u_color
  • missing in js: Use glClear to draw solid background fills if they are the bottommost layer
• icon
  • missing in native: convert mat4 exMatrix to a vec2 extrudeScale
• line
  • missing in native: separate u_opacity from u_color
  • missing in native: combine line-width and line-gap-width in shader
• linepattern
  • missing in native: combine line-width and line-gap-width in shader
  • minor organic difference
• linesdfpattern
  • missing in native: separate u_opacity from u_color
  • missing in native: combine line-width and line-gap-width in shader
• outline
  • missing in native: separate u_opacity from u_color
• outlinepattern
  • missing in native: separate pattern size from draw-time variables
• pattern
  • missing in native: separate pattern size from draw-time variables
• raster - native doesn't do crossfading (crossfade raster textures mapbox-gl-native#115):
  • crossfade raster tiles
  • let raster tiles fade in over background
  • clean up raster shader
• sdf
  • missing in native: separate u_opacity from u_color
  • missing in native: convert mat4 exMatrix to a vec2 extrudeScale
  • missing in js: don't clip glyphs with the frustum (Don't clip glyphs with the view frustum mapbox-gl-native#2081)

Note that the above links are to commits imported into gl-shaders from gl-js and gl-native: they include the shader changes, but not corresponding .js or .cpp changes. When porting, you'll want to loop up the original commit to see the related changes to .js or .cpp files.

[jfirebaugh]

@kkaefer Can you tell me about mapbox/mapbox-gl-native@e2fadf3? This is the one change I could find that was made in gl-native and not ported to gl-js, and it looks like it could be tricky to port because of conflicting changes to the sdf shader coming from the gl-js side. (cc @ansis)

[jfirebaugh]

Rough priorities for remaining convergence work:

• Reconcile minor remaining difference in linepattern shader. (Probably just pick one of the two lines, but I'm not sure which is preferable. cc @ansis)
• Port to native: convert mat4 exMatrix to a vec2 extrudeScale. In the sdf shader, it needs to be reconciled with don't clip glyphs with the frustum (Don't clip glyphs with the view frustum mapbox-gl-native#2081).
• Port to native: separate pattern size from draw-time variables. This will hopefully be straightforward for someone who understands the math.
• Minimize remaining differences in circle shader, short of requiring DDS implementation in gl-native.
• Launch DDS work in gl-native.
• Port raster cross-fading to native (crossfade raster textures mapbox-gl-native#115, low priority)

[brunoabinader]

Circle shader update is happening in #4 and mapbox/mapbox-gl-native#5191. Remaining #ifdefs in circle shader depends on mapbox/mapbox-gl-native#5174.

[brunoabinader]

Icon/SDF shader update: #5 and mapbox/mapbox-gl-native#5196.

[brunoabinader]

Pragma commands for GL Native: #6 and mapbox/mapbox-gl-native#5174.

[brunoabinader]

Line-pattern: minor organic difference fixed in mapbox/mapbox-gl-test-suite#107, #17, mapbox/mapbox-gl-js#2724 & mapbox/mapbox-gl-native#5327.

[brunoabinader]

[native] Separate pattern size from draw-time variables: #19, mapbox/mapbox-gl-test-suite#112, mapbox/mapbox-gl-native#5357 & mapbox/mapbox-gl-js#2743.

[brunoabinader]

[native] Overdraw inspector mode: mapbox/mapbox-gl-native#5403

[mourner]

Seems like everything is covered — no implementation-specific ifdefs left.