Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

make type layer property not a render property #80

Closed
ansis opened this issue Jul 3, 2014 · 1 comment
Closed

make type layer property not a render property #80

ansis opened this issue Jul 3, 2014 · 1 comment
Milestone
v4

Comments

@ansis
Copy link
Contributor

ansis commented Jul 3, 2014

Not that important, but I think type might fit a bit better one level up on the layer instead of on the render object.
@kkaefer
Copy link
Member

kkaefer commented Jul 3, 2014

Good idea, I've found that too; currently, the style parser needs to jump through a few hoops to figure out the layer type.

@jfirebaugh jfirebaugh mentioned this issue Jul 3, 2014
Merged
jfirebaugh added a commit to cutting-room-floor/mapbox-gl-style-lint that referenced this issue Jul 3, 2014
@jfirebaugh
Promote render type property to parent layer
48625c0 
mapbox/mapbox-gl-style-spec#80
@jfirebaugh jfirebaugh mentioned this issue Jul 3, 2014
Merged
This was referenced Jul 8, 2014
Closed
Merged
Merged
@mourner mourner closed this as completed Jul 8, 2014
@mourner mourner added this to the v4 milestone Jul 8, 2014
@kkaefer kkaefer mentioned this issue Jul 9, 2014
Closed
kkaefer added a commit to mapbox/mapbox-gl-native that referenced this issue Jul 10, 2014
@kkaefer
move render type to layer top level
d9bebe8 
refs mapbox/mapbox-gl-style-spec#80
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4
Development

No branches or pull requests
3 participants
@mourner @kkaefer @ansis