Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

change text-max-angle default and doc to degrees #100

Merged
merged 2 commits into from
Jul 14, 2014
Merged

change text-max-angle default and doc to degrees #100

merged 2 commits into from
Jul 14, 2014

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Jul 14, 2014

per #92 and related to mapbox/mapbox-gl-js#547
I changed the default to 50 degrees as a less crazy default than 180, but @nickidlugash it would be great if you had any input on what a sensible default might be? /cc @yhahn @ansis

@nickidlugash
Copy link
Contributor

@lbud I'm not sure what a good default might be – 50 deg sounds like a good ballpark (or maybe 45 deg, to be easier for users to envision?), but possibly something like 30 deg might look better. What happens though when it is not possible to place a label within the constraints of text-max-angle? Will the label not show up?

@ansis
Copy link
Contributor

ansis commented Jul 14, 2014

What happens though when it is not possible to place a label within the constraints of text-max-angle? Will the label not show up?

Yes, it won't show up.

@lbud
Copy link
Contributor Author

lbud commented Jul 14, 2014

@nickidlugash right -- I've been visually checking this out and generally it seems like when you zoom in far enough it tends to be able to find a long enough straight enough segment to place a label.
for example, at 50°:
angle50

vs at 0°
angle0

lbud added a commit that referenced this pull request Jul 14, 2014
change text-max-angle default and doc to degrees
@lbud lbud merged commit 84f3322 into master Jul 14, 2014
@jfirebaugh jfirebaugh deleted the angleDegrees branch July 15, 2014 18:50
@kkaefer kkaefer mentioned this pull request Jul 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants