Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

separate justification from alignment #74

Merged
merged 1 commit into from
Jul 1, 2014
Merged

separate justification from alignment #74

merged 1 commit into from
Jul 1, 2014

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Jul 1, 2014

The alignment properties control how the text is aligned relative to the anchor. Justification handles how text is aligned within each line.

Do the names look alright? thoughts on justification vs justify and alignment vs align?

@nickidlugash
Copy link
Contributor

My vote is for text-justify, text-align, and text-vertical-align.

I prefer "justify" and "align" to "justification" and "alignment" because they are shorter and more consistent with css properties/Adobe CC naming systems. I also prefer using just text-align to mean horizontal align for the same reasons, but text-horizontal-align is fine, too.

@mourner
Copy link
Member

mourner commented Jul 1, 2014

👍 to Nicki's suggestions

@ansis
Copy link
Contributor Author

ansis commented Jul 1, 2014

thanks @nickidlugash

I switched alignment to align.

I left text-horizontal-align instead of changing it to text-align because because text-align in css and carto does what text-justify does here. Would renaming text-justify to text-align be better?

I also switched center to middle for both horizontal and vertical alignment.

@nickidlugash
Copy link
Contributor

The parallels with other design terminology does get a bit confusing because justification is a property of text, while alignment is really a property of objects, including blocks of text. Adobe CC doesn't have a concept of "text alignment", only "object alignment", which can be applied to text frames. I don't particularly like css's use of "text-align" to mean "justify", but I agree that it could be confusing to use the same term to mean something else. text-horizontal-align sounds good.

I also switched center to middle for both horizontal and vertical alignment.

I personally prefer center, which is the terminology Adobe CC uses (but css uses "center" for horizontal, and "middle" for vertical).

@ansis
Copy link
Contributor Author

ansis commented Jul 1, 2014

Switched middle back to center

now we have:

  • text-justify: center, left, right
  • text-horizontal-align: center, left, right
  • text-vertical-align: center, top, bottom

good to merge?

@edenh
Copy link
Contributor

edenh commented Jul 1, 2014

text-horizontal-align should probably be text-align

ansis added a commit that referenced this pull request Jul 1, 2014
separate justification from alignment
@ansis ansis merged commit 8355240 into master Jul 1, 2014
@ansis ansis deleted the text-align branch July 1, 2014 22:16
@kkaefer kkaefer mentioned this pull request Jul 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants