This repository has been archived by the owner on Apr 10, 2018. It is now read-only.
Promote glyphs to a top level element #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Explanation: It doesn't make sense conceptually to have glyph SDFs scoped to sources. The glyph SDFs are a stylesheet thing, not a datasource-specific thing. even if you use multiple different data sources, you want to use the same fonts across layers, even if they are from different data sources. |
|
👍 |
ansis
added a commit
that referenced
this pull request
Jul 2, 2014
Promote glyphs to a top level element
This was referenced Jul 2, 2014
8 tasks
jfirebaugh
added a commit
to cutting-room-floor/mapbox-gl-style-lint
that referenced
this pull request
Jul 3, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, glyphs are specified in a source, but this doesn't make much sense, since multiple sources can use the same glyph endpoint. If we ever chose to support multiple glyph endpoints in a single stylesheet, we can revisit expanding this property later.