Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat & add default_marker to 1x for Emerald #43

Closed
wants to merge 1 commit into from

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Mar 22, 2015

Fixed the missing reference to default_marker in 1x; reformatted.

/cc @peterqliu

@incanus
Copy link
Contributor Author

incanus commented Mar 22, 2015

@peterqliu There are other problems in your 1x sheet:

"us_highway_1": {
  "height": 24,
  "pixelRatio": 1,
  "sdf": false,
  "width": 24.5,
  "x": 0,
  "y": 82
},

Namely that we can't have non-integer pixel values like the width here. I'm not sure what we normally do for halves like this, but this crashes the app hard as we assume integer values.

Aside from the fix, we need to test sprites on both 1x and 2x devices, as they are entirely different sprites. You can do this by testing on an iPad 2 simulator; that's the only one left these days that is supported by iOS 7 but that isn't retina.

@peterqliu
Copy link
Contributor

taken care of in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants