downgrade to java 7 #833
downgrade to java 7 #833
Conversation
osana
requested review from
tobrun and
LukasPaczos
and removed request for
tobrun and
LukasPaczos
There was a problem hiding this comment.
Would you be able to rebase on master? I'm not seeing https://github.com/mapbox/mapbox-java/blob/master/services-geojson/src/main/java/com/mapbox/geojson/Geometry.java#L26 being adressed which shouldn't compile with 1.7
| @@ -17,5 +17,5 @@ | |||
| * @return the {@link Point}s which make up the coordinates defining the geometry | |||
| * @since 3.0.0 | |||
| */ | |||
| T coordinates(); | |||
| public abstract T coordinates(); | |||
There was a problem hiding this comment.
the previous method was package private, can we retain that with this setup?
There was a problem hiding this comment.
This was part of an interface so when implemented it would have to be public
| @@ -84,7 +86,7 @@ public void testToFromJson1() { | |||
| .distance(53.4) | |||
| //.weight(14.3) | |||
| .duration(14.3) | |||
| .steps(new ArrayList<>()) | |||
| .steps(legSteps) | |||
There was a problem hiding this comment.
these changes seem unrelated but no biggy to keep them around
There was a problem hiding this comment.
For some reason it was giving me compilation error under java 7.
Casting was not possible for some reason.
| @@ -7,7 +7,7 @@ | |||
| * | |||
| * @since 1.0.0 | |||
| */ | |||
| public interface GeoJson { | |||
| public abstract class GeoJson { | |||
There was a problem hiding this comment.
geojson itself is public and changing it from an interface to an abstract class would be a breaking change as users using it will need to change implements to extends + if they are already extending an object, they won't be able to make this change due to java only supporting single inheritance.
There was a problem hiding this comment.
@tobrun Good point. I will create another PR then with the method just removed.
|
I did not have to remove |
closes #868
related to #832
java8 was introduced by #770 #749