Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation plugin] Avoid adding same image multi times #118

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 22, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #71

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>[Annotation plugin] Avoid adding same image multi times</changelog>.

Summary of changes

The same bitmap could be added to style for multi times if multi symbols use this bitmap.
This PR adds the check to avoid adding the same image multi times.

User impact (optional)

@Chaoba Chaoba self-assigned this Feb 22, 2021
@Chaoba Chaoba changed the title [Annotation plugin] Avoid add same image multi times [Annotation plugin] Avoid adding same image multi times Feb 22, 2021
@Chaoba Chaoba added the bug 🪲 Something isn't working label Feb 22, 2021
@Chaoba Chaoba requested a review from a team February 22, 2021 06:15
@Chaoba Chaoba merged commit 7fff505 into main Feb 22, 2021
@Chaoba Chaoba deleted the kl-add-image branch February 22, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid adding the same iconImageBitmap multi times.
2 participants