Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation plugin] Change annotations from map to list #121

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 23, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>[Annotation plugin] Change annotations from map to list</changelog>.

Summary of changes

The type of annotations in AnnotationManger is Map, which is not convenient for users. This pr change its type from Map to List.

User impact (optional)

@Chaoba Chaoba self-assigned this Feb 23, 2021
@Chaoba Chaoba requested a review from a team February 23, 2021 03:00
@Chaoba Chaoba merged commit d629cdb into main Feb 23, 2021
@Chaoba Chaoba deleted the kl-annotations branch February 23, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants