Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[location-component] Improve the default location provider and improve handling of location updates. #58

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Jan 29, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Improve the default location provider and improve handling of location updates.</changelog>.

Summary of changes

This PR improves the default location provider implementation by moving to the last known location when new location consumer is registered.
This PR also improves the handling when disabling the location component.

User impact (optional)

@pengdev pengdev self-assigned this Jan 29, 2021
@pengdev pengdev added the bug 🪲 Something isn't working label Jan 29, 2021
@pengdev pengdev requested a review from a team January 29, 2021 12:21
@pengdev pengdev force-pushed the peng-improve-default-location-provider branch from fac6645 to e3a90bc Compare January 29, 2021 13:26
@pengdev pengdev marked this pull request as ready for review January 29, 2021 13:31
@pengdev pengdev merged commit f80ea67 into main Jan 29, 2021
@pengdev pengdev deleted the peng-improve-default-location-provider branch January 29, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants