-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Annotation plugin] Add bitmap API for Symbol #67
Conversation
app/src/main/java/com/mapbox/maps/testapp/examples/annotation/SymbolActivity.kt
Outdated
Show resolved
Hide resolved
52fdf72
to
d5288b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One that this this issue isn't resolving yet is for the use-case of style loading. What will happen if I use the bitmap API and load a new style? The symbol is supposed to be shown again but the style image is not part of the style spritesheet. We need to take this use-case into account and readd style images when needed.
plugin-annotation/src/main/java/com/mapbox/maps/plugin/annotation/AnnotationManagerImpl.kt
Outdated
Show resolved
Hide resolved
Every time we change to a new style, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for first iteration. I do think we can improve one specific use-case below but we can do that as tailwork:
- what happens if a user adds 2 symbols using the same iconImageBitmap? It will currently add 2 bitmaps with 2 separate ids to the style. Ideally we only add one and reuse them.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-android
changelog:<changelog>[Annotation plugin] Add bitmap API for Symbol</changelog>
.Summary of changes
This pr add the bitmap API for Symbol to enable users to add a bitmap to Symbol directly instead of adding it to style.
User impact (optional)