[sdk] Use cached resourceOptions if it's initialized.

[Chaoba]

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

• Briefly describe the changes in this PR.
• Include before/after visuals or gifs if this PR includes visual changes.
• Write tests for all new functionality. If tests were not written, please explain why.
• Add example if relevant.
• Document any changes to public APIs.
• Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
• Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>[sdk] Use cached resourceOptions if it's initialized.</changelog>.

Summary of changes

This pr add the function that checks and use the cached resourceOptions if it's initialized instead of recreate it from ResourcesOptions

User impact (optional)

[kiryldz]

@Chaoba let's imagine we have 2 MapViews in one layout and we want to set different tokens to each of it programatically (and also different from <string name="mapbox_access_token"></string>) . Can it be done with current setup? If yes - guess we should provide an example in app module.

[pengdev]

nice catch!

[pengdev]

@Chaoba let's imagine we have 2 MapViews in one layout and we want to set different tokens to each of it programatically (and also different from <string name="mapbox_access_token"></string>) . Can it be done with current setup? If yes - guess we should provide an example in app module.

I guess it's hard to showcase this example without exposing the access token in the code.

[Chaoba]

@Chaoba let's imagine we have 2 MapViews in one layout and we want to set different tokens to each of it programatically (and also different from <string name="mapbox_access_token"></string>) . Can it be done with current setup? If yes - guess we should provide an example in app module.

@kiryldz Even without the changes in this pr, set different tokens to 2 MapView is available. This pr resolves the scenario that if users use interface MapboxOptions#setDefaultResourceOptions updated the ResourceOptions and create a new MapView, the updated ResourceOptions will not work on the new MapView.

[kiryldz]

@Chaoba let's imagine we have 2 MapViews in one layout and we want to set different tokens to each of it programatically (and also different from <string name="mapbox_access_token"></string>) . Can it be done with current setup? If yes - guess we should provide an example in app module.

I guess it's hard to showcase this example without exposing the access token in the code.

We could use any string and not make MapView show data (because token is invalid).
However that use-case is pretty real, I faced it myself in our Preview App, when valid token comes through web and gets saved to shared preferences and then must be used with MapView inflated from xml.

[kiryldz]

@Chaoba let's imagine we have 2 MapViews in one layout and we want to set different tokens to each of it programatically (and also different from <string name="mapbox_access_token"></string>) . Can it be done with current setup? If yes - guess we should provide an example in app module.

@kiryldz Even without the changes in this pr, set different tokens to 2 MapView is available. This pr resolves the scenario that if users use interface MapboxOptions#setDefaultResourceOptions updated the ResourceOptions and create a new MapView, the updated ResourceOptions will not work on the new MapView.

My concern here is that our current logic will work fine with 1 MapView in xml - then we could MapboxOptions#setDefaultResourceOptions before setContentView in activity. But if we have 2 MapViews in the layout and each of it should have it's own token - that will not work I guess.
Generally such scenario should not be pretty common but anyway.

[kiryldz]

LGTM, created a task to track revisiting approach in general.