Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rendering] Expose setting FPS listener #80

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Feb 5, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
<changelog>[rendering] Expose setting FPS listener</changelog>

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.

Summary of changes

Expose setting listener to measure FPS for map rendering and show FPS in debug activity example.

User impact (optional)

Breaking change in terms of extending public interface MapControllable.

@kiryldz kiryldz requested a review from a team February 5, 2021 09:13
@kiryldz kiryldz self-assigned this Feb 5, 2021
@kiryldz kiryldz force-pushed the kdz-expose-fps-listener branch from 7c57860 to b1090b3 Compare February 5, 2021 09:48
@kiryldz kiryldz force-pushed the kdz-expose-fps-listener branch from b1090b3 to 40498e0 Compare February 5, 2021 15:07
@kiryldz kiryldz merged commit 0fa59c3 into main Feb 5, 2021
@kiryldz kiryldz deleted the kdz-expose-fps-listener branch February 5, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants