Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core to v10.0.0-beta.14 and common to v10.0.0-beta.9.1 #87

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Update core to v10.0.0-beta.14 and common to v10.0.0-beta.9.1 #87

merged 2 commits into from
Feb 10, 2021

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Feb 9, 2021 •
edited
Loading

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
<changelog>Update core to v10.0.0-beta.14 and common to v10.0.0-beta.9.1</changelog>

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.

Summary of changes

User impact (optional)

@kiryldz kiryldz self-assigned this Feb 9, 2021
@kiryldz kiryldz requested a review from a team February 9, 2021 14:47
@kiryldz kiryldz marked this pull request as ready for review February 9, 2021 14:50
@kiryldz kiryldz changed the title Update core to v10.0.0-beta.14 and common to v10.0.0-beta.9 Update core to v10.0.0-beta.14 and common to v10.0.0-beta.9.1 Feb 10, 2021
tobrun
tobrun requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the style bot passes! :shipit:

@tobrun tobrun self-requested a review February 10, 2021 14:27
@kiryldz
Copy link
Contributor Author

kiryldz commented Feb 10, 2021

LGTM if the style bot passes! :shipit:

I'm re-running it for third time I guess 😫 😫 😫

@kiryldz kiryldz merged commit 42c31b8 into main Feb 10, 2021
@kiryldz kiryldz deleted the kdz-simple-bump-beta.14 branch February 10, 2021 15:18
@maratsct maratsct mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@kiryldz kiryldz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiryldz @tobrun