Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MapStyleStateDelegate, use native isStyleLoaded. #94

Closed
wants to merge 1 commit into from

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Feb 11, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.

Summary of changes

This PR remove MapStyleStateDelegate, use native isStyleLoaded.

User impact (optional)

@pengdev
Copy link
Member Author

pengdev commented Apr 22, 2021

Closing as the native API behaves differently than the platform cached isStyleLoaded. i.e. the native isStyleLoaded will become false when the new runtime source/layer is added to the style.

We should keep using the platform cached isStyleLoaded for now.

@pengdev pengdev closed this Apr 22, 2021
@pengdev pengdev deleted the peng-use-native-is-style-loaded branch April 22, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant