Fix crash after creating/destroying multiple Snapshotters
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
I noticed that there's a crash when opening/closing the snapshotter example repeatedly.
Upon investigation it turns out that the finalizer we use to cleanup after an instance of
Snapshotterhas been disposed doesn't have a detach token thus it never detaches which causes new instances(ofSnapshotter) to be cleaned up together with the instances that are going away.What is the motivation and context behind this change?
Fixing a rare crash in
Snapshotter.Pull request checklist: