Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Apple Silicon #48

Closed
julianrex opened this issue Jan 27, 2021 · 2 comments
Closed

Supporting Apple Silicon #48

julianrex opened this issue Jan 27, 2021 · 2 comments
Labels
feature 🍏 When working on a new feature or feature enhancement

Comments

@julianrex
Copy link
Contributor

Apple Silicon

Supporting Apple Silicon is an important goal for the Maps SDK. This means enabling Apple Silicon M1 Macs to be used as both development machines as well as deployment targets, allowing developers to build new and unique experiences for the desktop.

Now that the SDK and our dependencies support XCFrameworks and Swift Package Manager, we can address the following remaining tasks:

  • Ensure all dependencies contain arm64 simulator slices
  • Migrate SDK development from using Carthage to SPM internally.
  • Remove all existing Xcode 12 / arm64 simulator hacks from makefiles and Xcode configurations.
  • Update Cocoapods podspecs similarly

These unblock us from being able to provide Apple Silicon support via XCFrameworks, and to support Xcode 12.3+ without hacks.

@1ec5
Copy link
Contributor

1ec5 commented Feb 23, 2021

Ensure all dependencies contain arm64 simulator slices

MapboxMaps contains an arm64 simulator slice:

xcodebuild -create-xcframework \
-framework tmp_xcframework/$1/arm64/$1.framework \
-framework tmp_xcframework/$1/x86_64/$1.framework \
-output $3/$1.xcframework

Presumably MapboxCoreMaps does as well. This script strips it out, but I don’t think the script is used anywhere:

lipo -create \
"$1/ios-arm64/MapboxCoreMaps.framework/MapboxCoreMaps" \
MapboxCoreMaps_x86_64 \
-output "$2/MapboxCoreMaps"

If I’m not mistaken, MapboxCommon already contains an arm64 simulator slice. Now that #118 and #125 have landed, are there any other binary dependencies blocking Apple Silicon support?

@macdrevx
Copy link
Contributor

macdrevx commented Mar 9, 2021

This was resolved with beta 14: https://github.com/mapbox/mapbox-maps-ios/releases/tag/v10.0.0-beta.14

@macdrevx macdrevx closed this as completed Mar 9, 2021
persidskiy pushed a commit that referenced this issue Feb 24, 2023
* Send unique report per each run measurement (#1633)

* Prevent view annotation being shown erroneously after options update (#1627)

Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Development

No branches or pull requests

4 participants