Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PointAnnotationManager.swift #1825

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

maios
Copy link
Contributor

@maios maios commented Dec 22, 2022

Upstream PR https://github.com/mapbox/mapbox-maps-ios-internal/pull/1303
I accidentally modified generated files manually when rebasing #1775 :(

Also fixed MAPSIOS-540

@maios maios requested a review from a team as a code owner December 22, 2022 10:18
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1825 (a1e5f0c) into main (a82f440) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   84.36%   84.37%           
=======================================
  Files         242      242           
  Lines       15027    15026    -1     
=======================================
  Hits        12678    12678           
+ Misses       2349     2348    -1     
Flag Coverage Δ
integration 18.34% <0.00%> (+<0.01%) ⬆️
unit 83.28% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...boxMaps/Annotations/AnnotationManagerFactory.swift 92.45% <100.00%> (+0.14%) ⬆️
...Annotations/Generated/PointAnnotationManager.swift 92.37% <100.00%> (-0.04%) ⬇️
...boxMaps/Foundation/Extensions/Core/MapEvents.swift 82.35% <0.00%> (-5.89%) ⬇️
...Maps/Style/Generated/Sources/RasterDemSource.swift 94.11% <0.00%> (-5.89%) ⬇️
Sources/MapboxMaps/Style/SourceType.swift 81.25% <0.00%> (ø)
...boxMaps/Annotations/OffsetGeometryCalculator.swift 68.53% <0.00%> (+0.56%) ⬆️
Sources/MapboxMaps/Offline/OfflineErrors.swift 45.61% <0.00%> (+1.75%) ⬆️
...boxMaps/Style/Generated/Sources/VectorSource.swift 100.00% <0.00%> (+5.88%) ⬆️

@maios maios merged commit 8b79a40 into main Dec 22, 2022
@maios maios deleted the mai/update-generated-annotation-manager branch December 22, 2022 13:00
persidskiy pushed a commit that referenced this pull request Feb 24, 2023
* Update PointAnnotationManager.swift

* Fix clusterOptions not being passed to PointAnnotationManager initializer.

Co-authored-by: Mai Mai <mai.mai@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants