Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and expose CompassDirectionFormatter #300

Merged
merged 2 commits into from
May 4, 2021

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Apr 26, 2021

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update changelog
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc No changes

Summary of changes

  • CompassDirectionFormatter is now public. It provides a string representation of a CLLocationDirection and supports the same languages as in pre-v10 versions of the Maps SDK.

@macdrevx macdrevx added the feature 🍏 When working on a new feature or feature enhancement label Apr 26, 2021
@macdrevx macdrevx force-pushed the ah/compass-direction-formatter branch from dd6cc3b to 10f47b0 Compare April 26, 2021 14:29
@macdrevx macdrevx marked this pull request as draft April 26, 2021 14:44
@macdrevx macdrevx force-pushed the ah/compass-direction-formatter branch from 10f47b0 to 116022f Compare April 26, 2021 15:09
@macdrevx macdrevx marked this pull request as ready for review April 26, 2021 15:26
@macdrevx macdrevx requested a review from jmkiley April 26, 2021 17:13
@jmkiley jmkiley enabled auto-merge (squash) May 4, 2021 17:15
@jmkiley jmkiley merged commit 86ab83e into main May 4, 2021
@jmkiley jmkiley deleted the ah/compass-direction-formatter branch May 4, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants