Add internal map delegates, create platform Projection class #390
Conversation
julianrex
added
the
breaking change ⚠️
|
Not sure what testing the protocol will give us, but will add a couple of small tests to test some assumptions (e.g. conformance) |
They are simple pass through functions, but unit tests for those will help us Catch any breaking changes upstream from Core. It will be a nice catch all |
| static func unproject(_ mercatorCoordinate: MercatorCoordinate, zoomScale: CGFloat) -> CLLocationCoordinate2D | ||
| } | ||
|
|
||
| public class Projection: MapProjectionDelegate { |
There was a problem hiding this comment.
On Android the MapboxMap : MapProjectionDelegate to be more discoverable, where the functions inside MapProjectionDelegate are not static.
gl-native exposed generated static APIs can be directly used as Projection.project(point, zoomScale).
There was a problem hiding this comment.
Let's leave this as a point of difference? At the moment there's no need on iOS because of the lack of plugins. /cc @tobrun
| _ = map as CameraManagerProtocol | ||
| _ = map as MapFeatureQueryable | ||
| _ = map as ObservableProtocol | ||
| _ = map as MapEventsObservable |
There was a problem hiding this comment.
Nice, this is an interesting concept as a test I like it
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Pull request checklist:
mapbox-maps-ioschangelog:<changelog></changelog>.Summary of changes
This PR:
MapTransformDelegateandMapProjectionDelegateprotocols, both currentlyinternalProjectionclass that implementsMapProjectionDelegate, shadowing the one from MapboxCoreMaps.tileRegionGeometryThe two protocols match Android, except for
getMetersPerPixelAtLatitude(latitude: Double). Also on AndroidMapboxMapconforms toMapProjectionDelegate, for iOS it's a new platformProjectionDeveloper impact
Developers will need to update any existing use of
Projectionin their code.