Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CameraAnimationsManager.setCamera in favor of CameraManagerProtocol.setCamera #426

Merged
merged 8 commits into from
Jun 3, 2021

Conversation

jmkiley
Copy link
Contributor

@jmkiley jmkiley commented Jun 2, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR removes CameraAnimationsManager.setCamera and renames CameraManagerProtocol._setCamera to CameraManagerProtocol.setCamera. setCamera can now be called on mapView.mapboxMap.

User impact (optional)

@jmkiley jmkiley added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label Jun 2, 2021
@jmkiley jmkiley self-assigned this Jun 2, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jmkiley
❌ Jordan Kiley


Jordan Kiley seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jmkiley jmkiley changed the title Remove CameraAnimationsManager.setCamera in favor of CameraManagerProtocol._setCamera Remove CameraAnimationsManager.setCamera in favor of CameraManagerProtocol.setCamera Jun 2, 2021
@jmkiley jmkiley requested a review from julianrex June 2, 2021 20:43
@jmkiley jmkiley marked this pull request as ready for review June 2, 2021 20:43
CHANGELOG.md Outdated Show resolved Hide resolved
@jmkiley jmkiley merged commit f28e9c4 into main Jun 3, 2021
@jmkiley jmkiley deleted the jk/remove-setCamera branch June 3, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants