-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CameraAnimationsManager.setCamera
in favor of CameraManagerProtocol.setCamera
#426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan Kiley seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
CameraAnimationsManager.setCamera
in favor of CameraManagerProtocol._setCamera
CameraAnimationsManager.setCamera
in favor of CameraManagerProtocol.setCamera
neelmistry94
reviewed
Jun 2, 2021
neelmistry94
reviewed
Jun 2, 2021
Sources/MapboxMaps/Gestures/GestureManager+GestureHandlerDelegate.swift
Outdated
Show resolved
Hide resolved
neelmistry94
reviewed
Jun 2, 2021
Sources/MapboxMaps/Gestures/GestureManager+GestureHandlerDelegate.swift
Outdated
Show resolved
Hide resolved
neelmistry94
reviewed
Jun 3, 2021
neelmistry94
approved these changes
Jun 3, 2021
julianrex
reviewed
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ios
changelog:<changelog></changelog>
.Summary of changes
This PR removes
CameraAnimationsManager.setCamera
and renamesCameraManagerProtocol._setCamera
toCameraManagerProtocol.setCamera
.setCamera
can now be called onmapView.mapboxMap
.User impact (optional)