Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gesture recognizers directly on MapView.GestureManager #450

Merged
merged 4 commits into from
Jun 10, 2021

Conversation

nishant-karajgikar
Copy link
Contributor

@nishant-karajgikar nishant-karajgikar commented Jun 9, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Gesutre Recognizers added to the mapView are exposed as properties on mapView.gestures</changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR adds computed vars to the public interface of MapView.GestureManager which allow for a developer to inspect (and potentially become the GestureRecognizerDelegate of) stock gestures that are set on the map.

@macdrevx
Copy link
Contributor

macdrevx commented Jun 9, 2021

What do you think of making the property types simply UIGestureRecognizer that way we're less tied to a specific implementation?

@nishant-karajgikar
Copy link
Contributor Author

What do you think of making the property types simply UIGestureRecognizer that way we're less tied to a specific implementation?

Yep, I'm not opposed to that. Will update.

@nishant-karajgikar nishant-karajgikar merged commit 44fc3fc into main Jun 10, 2021
@nishant-karajgikar nishant-karajgikar deleted the nishantk/gestures branch June 10, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants