Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable show/hide for location puck accuracyRadius #629

Merged
merged 10 commits into from
Sep 8, 2021
Merged

Enable show/hide for location puck accuracyRadius #629

merged 10 commits into from
Sep 8, 2021

Conversation

neelmistry94
Copy link
Contributor

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'

Summary of changes

This PR updates the Puck2DConfiguration to have a flag for accuracyRadius. This value will be false (disabled) by default. This PR also updates the customization example to bring some clarity to this.

@neelmistry94 neelmistry94 added the feature 🍏 When working on a new feature or feature enhancement label Aug 27, 2021
@neelmistry94 neelmistry94 enabled auto-merge (squash) August 27, 2021 18:24
@neelmistry94 neelmistry94 force-pushed the nm/disable_accuracy_radius branch 2 times, most recently from 7d941ef to 0528736 Compare August 31, 2021 16:54
macdrevx
macdrevx reviewed Sep 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@neelmistry94 neelmistry94 merged commit 52420ff into main Sep 8, 2021
@neelmistry94 neelmistry94 deleted the nm/disable_accuracy_radius branch September 8, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdrevx macdrevx macdrevx approved these changes

Assignees
No one assigned
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neelmistry94 @macdrevx