Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a property for getting/setting the map's debug option #648

Merged
merged 7 commits into from
Sep 10, 2021

Conversation

jmkiley
Copy link
Contributor

@jmkiley jmkiley commented Sep 3, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: #541

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Allow users to set the map's MapDebugOptions.</changelog>.

Summary of changes

This PR adds a debugOptions property to MapboxMap. This property is an array of MapDebugOptions. Like prefetchZoomDelta, this property acts a both a getter and a setter. The getter calls the core getDebugOptions method and converts the returned [NSNumber] into [MapDebugOptions]. The setter removes the previous debugOptions value and then sets the debugOptions to the new value.

User impact (optional)

@jmkiley jmkiley added the feature 🍏 When working on a new feature or feature enhancement label Sep 3, 2021
@jmkiley jmkiley self-assigned this Sep 3, 2021
Copy link
Contributor

@macdrevx macdrevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests.

@jmkiley jmkiley merged commit 2564951 into main Sep 10, 2021
@jmkiley jmkiley deleted the jk/mapdebugoptions branch September 10, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap methods for getting and setting MapDebugOptions
2 participants