Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nm/fix geometry in tile store 2 #661

Merged
merged 7 commits into from
Sep 8, 2021
Merged

Conversation

neelmistry94
Copy link
Contributor

@neelmistry94 neelmistry94 commented Sep 8, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'

Summary of changes

This is changing the return type for the tileRegionGeometry function to return a Turf Geometry instead of a Common Geometry. This is achieved by adding a code block with default implementation to the callback creator.

CHANGELOG.md Outdated Show resolved Hide resolved
@neelmistry94 neelmistry94 added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label Sep 8, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@neelmistry94 neelmistry94 merged commit 83a3308 into main Sep 8, 2021
@neelmistry94 neelmistry94 deleted the nm/fix_geometry_in_tileStore_2 branch September 8, 2021 17:53
OdNairy pushed a commit that referenced this pull request Aug 22, 2023
Add Studio Preview to the release template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants